-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed "The set-output
command is deprecated and will be disabled soon" alert
#82
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitalykarasik shouldn't the following set-output usage in ci.yml be updated as well to fully resolve this issue?
@jacob-briscoe - thank you, makes sense, fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me! Nice job.
We'll need a maintainer to approve this change.
Came to find this, thanks for taking the initiative and getting it done. Can we get this merged, @ebinmore ? This is a really useful action! |
Anyone? |
This looks good and is a simple update that follows GitHub recommendations. It should be merged soon since GitHub has announced the deprecated functionality will be disabled soon. |
Can we get this merged please? 😄 |
Thanks for getting this started! We use this action in many of our workflows, and getting it updated will be useful for us. Taking a quick look at the PR, it looks like there's both a |
Should we wait for this or the message is clear and this repo is abandoned? |
@csaba-kovacs I'm confused about your comment. Is this repo supposed to be abandoned? Edit: Oh I see what you meant... 4 months without response, I didn't see it was open for so long. |
@ebinmore |
|
This repo is abandoned: #69 (comment) Anyone here will to establish themselves as the primary fork moving forward? |
@aldenquimby I can't commit to any further maintenance, but I applied the changes in this PR to my forked branch and published it here: https://github.com/marketplace/actions/gha-slack-notify-build |
node20 and other updates
Hi @vitalykarasik, is there any published version with recent changes in which you have upgraded the node version? If so, can you kindly share the link or the action name that I should use? @justinr636 Can you also copy the changes and publish a latest version in this action? We are getting deprecation notice for node v16 |
@MohamedAsan |
You can use mine. I did the upgrade. |
@csaba-kovacs Awesome, thanks a lot 💪 |
Purpose
Fixed "The
set-output
command is deprecated and will be disabled soon" alert.See #71
Important Changes
Bumped @actions/core to 1.10.0